linux-mips
[Top] [All Lists]

Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: Tue, 25 Jun 2013 01:04:29 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <51C89567.3000108@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372023524-17333-1-git-send-email-aaro.koskinen@iki.fi> <51C89567.3000108@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 24, 2013 at 11:52:23AM -0700, David Daney wrote:
> On 06/23/2013 02:38 PM, Aaro Koskinen wrote:
> >When booting a new board for the first time, the console is flooded with
> >"Unknown board" messages. This is not really helpful. Board type is not
> >going to change after the boot, so it's sufficient to print the warning
> >only once.
> >
> >Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> 
> I don't think we need this patch.  In 2/2 you add the board type for
> the board you have, so you shouldn't be getting any messages, and
> this is unneeded.
> 
> I don't mind spamming people with all the messages,  if people see
> these messages, they have bigger problems than too many messages.

I guess this patch can be dropped, but whoever tries to improve the
support for the next new Octeon board will get annoyed by these same
messages...

A.

<Prev in Thread] Current Thread [Next in Thread>