linux-mips
[Top] [All Lists]

Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-feature

To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Subject: Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h
From: Tony Wu <tung7970@gmail.com>
Date: Thu, 20 Jun 2013 17:50:35 +0800
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Ralf Baechle <ralf@linux-mips.org>, "Maciej W. Rozycki" <macro@linux-mips.org>, david.daney@cavium.com, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=E9W0oZMcs2PH09NC7CYGtJnuOx7sB5cu7mN2QTtoH0M=; b=maoTThYUiLqYug+4V78BivHDaovP56rEMaxWqt+nETIQpXRLKzfR2nLt7yrSZ4FzYI Tee7YQN3suQexdMMg9f3Wf/PsahI4IioGfDWfb6CBKXXiOJeRu8CB1M4umFeCuEsJ3mT k5VgpcSwfUWut0lMGQgR7Yw+5orOE+ZNykgWg+kBK0R61oBiP01wRZkB2nk7lQaapB+i BdoNS/pd8B+8wX0kb780VL9YDFZJX0dUFH4Rq2tNfAfXFmeIkDMY5NR936oE0o1UHN2X M1FckHPY4AoT7k6Y9Y+N6YUMQwXtzJnu8lbO0gcngs+wDPk5XxB2qD7wUKqmWSyjcOxT UAnw==
In-reply-to: <51C22901.7050709@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130527124421.GA32322@hades> <20130527124557.GB32322@hades> <51A36EE6.3040901@cogentembedded.com> <51C22901.7050709@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, Jun 20, 2013 at 5:56 AM, Steven J. Hill <Steven.Hill@imgtec.com> wrote:
On 05/27/2013 09:34 AM, Sergei Shtylyov wrote:
Hello.

On 27-05-2013 16:45, Tony Wu wrote:

Add kernel_uses_mmips to denote whether CONFIG_CPU_MICROMIPS
is set or not. This variable can help cut down #ifdef usage.

    You can avoid #ifdef usage with using IS_BUILTIN() macro, not
defining extra macros.

Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: David Daney <david.daney@cavium.com>
Cc: Steven J. Hill <Steven.Hill@imgtec.com>

WBR, Sergei


I think this patch is not needed with <http://patchwork.linux-mips.org/patch/5327/> being used instead?

-Steve


I think cpu_has_mmips does not necessary mean kernel is compiled using microMIPS ISA, so I added kernel_uses_mmips for that purpose. We can remove this patch, but the third patch of this patch set will need some modifications. I will send new patches later.

Thanks,
Tony
<Prev in Thread] Current Thread [Next in Thread>