linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Fix OCTEON BUG() warnings a different way.

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] MIPS: Fix OCTEON BUG() warnings a different way.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 20 Jun 2013 16:26:25 +0200
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>, linux-kernel@vger.kernel.org
In-reply-to: <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 19, 2013 at 03:04:28PM -0700, David Daney wrote:

> Signed-off-by: David Daney <david.daney@cavium.com>

I replaced my fix with your fix but left he direct inclusion of
<linux/bug.h>.

Let as homework for a later point: make BUG() invoke unreachable() if
CONFIG_BUG is diabled, something like that.  This will improve code
generation for GCC 4.5+ but for older compilers unreachable() is
defined as do { } while (1) so will emit extra code.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>