linux-mips
[Top] [All Lists]

Re: [PATCH v2] mips: delete __cpuinit/__CPUINIT usage from MIPS code

To: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH v2] mips: delete __cpuinit/__CPUINIT usage from MIPS code
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 20 Jun 2013 15:55:42 +0200
Cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <51C305E4.4080705@windriver.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371566339-18336-1-git-send-email-paul.gortmaker@windriver.com> <51C22E75.3020001@gmail.com> <20130620002806.GA15693@windriver.com> <20130620021550.GA17009@linux-mips.org> <51C305E4.4080705@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 20, 2013 at 09:38:44AM -0400, Paul Gortmaker wrote:

> Thanks!  I realized I'd not cleaned up modpost last night while writing
> up the linux-arch mail (not yet sent) and added it to the patch queue:
> 
> http://git.kernel.org/cgit/linux/kernel/git/paulg/cpuinit-delete.git/log/
> 
> I had the dummied out init in the patch queue, but I didn't have linker
> script change yet -- I'll add that in today.

Testing this for MIPS I found that it fixes ALL the section conflicts
which I was observing (but haven't yet found the time to investigate)
until recently.  So from my point of view making __cpu{init,exec}* a no-op
is a bug fix.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>