linux-mips
[Top] [All Lists]

RE: [PATCH 2/2] netdev: octeon_mgmt: Fix structure layout for little-end

To: "David Daney" <ddaney.cavm@gmail.com>, <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH 2/2] netdev: octeon_mgmt: Fix structure layout for little-endian.
From: "David Laight" <David.Laight@ACULAB.COM>
Date: Thu, 20 Jun 2013 10:47:57 +0100
Cc: <linux-mips@linux-mips.org>, "David Daney" <david.daney@cavium.com>
In-reply-to: <1371688820-4585-3-git-send-email-ddaney.cavm@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371688820-4585-1-git-send-email-ddaney.cavm@gmail.com> <1371688820-4585-3-git-send-email-ddaney.cavm@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: Ac5tTtTVtO0JZvIHSES0j4PgHSGhEAATDZ1Q
Thread-topic: [PATCH 2/2] netdev: octeon_mgmt: Fix structure layout for little-endian.
> The C ABI reverses the bitfield fill order when compiled as
> little-endian.

No - it is completely implementation defined.
The general concensus is not to use bitfields if you
care at all about the bit assignments.

        David




<Prev in Thread] Current Thread [Next in Thread>