linux-mips
[Top] [All Lists]

Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-feature

To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
Date: Wed, 19 Jun 2013 16:56:17 -0500
Cc: Tony Wu <tung7970@gmail.com>, <ralf@linux-mips.org>, <macro@linux-mips.org>, <david.daney@cavium.com>, <linux-mips@linux-mips.org>
In-reply-to: <51A36EE6.3040901@cogentembedded.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130527124421.GA32322@hades> <20130527124557.GB32322@hades> <51A36EE6.3040901@cogentembedded.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
On 05/27/2013 09:34 AM, Sergei Shtylyov wrote:
Hello.

On 27-05-2013 16:45, Tony Wu wrote:

Add kernel_uses_mmips to denote whether CONFIG_CPU_MICROMIPS
is set or not. This variable can help cut down #ifdef usage.

    You can avoid #ifdef usage with using IS_BUILTIN() macro, not
defining extra macros.

Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: David Daney <david.daney@cavium.com>
Cc: Steven J. Hill <Steven.Hill@imgtec.com>

WBR, Sergei


I think this patch is not needed with <http://patchwork.linux-mips.org/patch/5327/> being used instead?

-Steve


<Prev in Thread] Current Thread [Next in Thread>