linux-mips
[Top] [All Lists]

Re: [PATCH 3/5] tty/8250_dw: Add support for OCTEON UARTS.

To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 3/5] tty/8250_dw: Add support for OCTEON UARTS.
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 19 Jun 2013 09:47:08 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Jamie Iles <jamie@jamieiles.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.cz>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=uJmellDy5B27WaPUjs6tQsNxG1GdVAPGUnPeT7gtf0s=; b=cwBY5R5EmnBhe1a1pYvhFUvpPNWDD0L/gpzWf1EfA1602amnjQihxjAAHFFr/Ck+rh HMfgr7lqBfMTt1LPsPhIeI08ASQ/F1dmoOF0OuV5o/Lju8TArXKxRbkxoeqKvC7UqtpI SKAuPdoA55mxo5ciKUzJ60vWtpcPUNtUD/xiBlIoGA59m1U6qVc7lb8vm5+dTAJ27InO VfVUpHyXmFZwRQqUGb44fmxqoKVuWVz7KB6rtJ7kf5S1xzk6bq7bRT/eMxUg0kj7r8Es yXP5vOEKWyBk9KN+c9MA1U3kzrOmUf4fDDbZM9A8ZivufNjv4OXRoOpVVo7IsoHfXsh3 KoYg==
In-reply-to: <20130619141008.GA32331@xps8300>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371582775-12141-1-git-send-email-ddaney.cavm@gmail.com> <1371582775-12141-4-git-send-email-ddaney.cavm@gmail.com> <20130619141008.GA32331@xps8300>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
On 06/19/2013 07:10 AM, Heikki Krogerus wrote:
On Tue, Jun 18, 2013 at 12:12:53PM -0700, David Daney wrote:
A few differences needed by OCTEON:

o These are DWC UARTS, but have USR at a different offset.

o OCTEON must have 64-bit wide register accesses, so we have OCTEON
   specific register accessors.

o No UCV register, so we hard code some properties.

Signed-off-by: David Daney <david.daney@cavium.com>

<snip>

@@ -270,10 +301,8 @@ static int dw8250_probe(struct platform_device *pdev)
        uart.port.serial_out = dw8250_serial_out;
        uart.port.private_data = data;

-       dw8250_setup_port(&uart);
-
        if (pdev->dev.of_node) {
-               err = dw8250_probe_of(&uart.port);
+               err = dw8250_probe_of(&uart.port, data);
                if (err)
                        return err;
        } else if (ACPI_HANDLE(&pdev->dev)) {
@@ -284,6 +313,9 @@ static int dw8250_probe(struct platform_device *pdev)
                return -ENODEV;
        }

+       if (!data->no_ucv)
+               dw8250_setup_port(&uart);

Moving the dw8250_setup_port() call here breaks dw8250_probe_acpi(). It
expects values from the CPR register for the DMA burst size calculation.

The DMA support can be moved to a separate function. This way it can
be called after this point, and it will then be available for both DT
and ACPI. I can make a patch tomorrow. That should solve this issue.


I am reworking the patch because other problems were found. I will try to get this part right in the next version.

David Daney


<Prev in Thread] Current Thread [Next in Thread>