linux-mips
[Top] [All Lists]

Re: [PATCH v2 5/7] drivers: watchdog: sb_wdog: Fix 32bit linking problem

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2 5/7] drivers: watchdog: sb_wdog: Fix 32bit linking problems
From: Yousong Zhou <yszhou4tech@gmail.com>
Date: Wed, 19 Jun 2013 15:45:07 +0800
Cc: Markos Chandras <markos.chandras@imgtec.com>, linux-mips@linux-mips.org, sibyte-users@bitmover.com, Wim Van Sebroeck <wim@iguana.be>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LH2NhKlPkmnHZxBagBZrVwiDVlwi+vGy07lzmNghOic=; b=jRGo3lWxhLcM4EWS1nGiI3CFu3vgvaEmnn5mK5uxb7BQuXwowwisH2m/Ta6fVFSYuF 0GVtUC0GzemScDXxLuo03kIxKfiKyP+fiQ7Hjqq2DMtyTNwFlqoYSQ0c9rsEVWVa9YIx rtOOA8Q3Dw9BX2e+b+o1ytaqTH7vmu+Ot+nKdMnD0G9boRn92TpIpWBulBxDtRiU3xH2 4p030LRfhcCuh+vv1BAaVIcqixRyOvcQDJ3XeiP7mdkTMA8il8NrhixkXe8o+d+iBY1L 8bU4IlCB/jVrBiDrlwA0Mn6+HU4fXxEX4oWbEpiyplyhLXMKF2z8Tzzo3FmdrKiXixFg ryEw==
In-reply-to: <20130618141420.GA15141@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371564006-31805-1-git-send-email-markos.chandras@imgtec.com> <20130618141420.GA15141@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
I am not quite sure on this. I just digged this[1] out and thought that Linus
 may not be happy about the operation `tmp_user_dog/1000000`.

Correct me if I am wrong, please.

[1] http://lwn.net/Articles/456241/

On 18 June 2013 22:14, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Tue, Jun 18, 2013 at 03:00:06PM +0100, Markos Chandras wrote:
>
>> Fixes the following linking problem:
>> drivers/watchdog/sb_wdog.c:211: undefined reference to `__udivdi3'
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> Cc: sibyte-users@bitmover.com
>> Cc: Wim Van Sebroeck <wim@iguana.be>
>> ---
>> This patch is for the upstream-sfr/mips-for-linux-next tree
>
> That looks ok.
>
> Wim, are going to merge this or shall I carry it?  If you take it,
> feel free to add my Acked-by.
>
> Thanks,
>
>   Ralf
>

<Prev in Thread] Current Thread [Next in Thread>