linux-mips
[Top] [All Lists]

Re: [PATCH 3/7] MIPS: sibyte: Add missing sched.h header

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 3/7] MIPS: sibyte: Add missing sched.h header
From: Peter Zijlstra <peterz@infradead.org>
Date: Mon, 17 Jun 2013 20:33:34 +0200
Cc: Markos Chandras <markos.chandras@imgtec.com>, linux-mips@linux-mips.org, sibyte-users@bitmover.com, linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
In-reply-to: <20130617164427.GE10408@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371477641-7989-1-git-send-email-markos.chandras@imgtec.com> <1371477641-7989-4-git-send-email-markos.chandras@imgtec.com> <20130617164427.GE10408@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2012-12-30)
On Mon, Jun 17, 2013 at 06:44:27PM +0200, Ralf Baechle wrote:
> On Mon, Jun 17, 2013 at 03:00:37PM +0100, Markos Chandras wrote:
> 
> > It's needed for the TASK_INTERRUPTIBLE definition.
> > 
> > Fixes the following build problem:
> > arch/mips/sibyte/common/sb_tbprof.c:235:4: error: 'TASK_INTERRUPTIBLE'
> > undeclared (first use in this function)
> 
> Ideally sched.h should be included into the actual user of
> TASK_INTERRUPTIBLE, the wake_up_interruptible macro in <linux/wait.h> but
> that seems way too risky that close to a release.

Oh man, there's include recursion hell waiting for you ;-)

<Prev in Thread] Current Thread [Next in Thread>