linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
Date: Thu, 13 Jun 2013 16:00:19 -0500
Cc: <linux-mips@linux-mips.org>
In-reply-to: <20130613141820.GB22906@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371075656-21374-1-git-send-email-Steven.Hill@imgtec.com> <20130613141820.GB22906@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
On 06/13/2013 09:18 AM, Ralf Baechle wrote:
On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:

I think this is going to break Malta.  We used to have:

     #define SOFTRES_REG       0x1e800050
     #define GORESET           0x4d

for SEAD

Yes, it does break Malta. The #define values are defined in two places and I missed one of them. I have submitted a patchset to these cleaned up. Both platforms can now perform soft resets. Also, the 0x1e800050 is not correct. I check all the way back in our 2.6.32.15 tree and that value does not show up anywhere. The value in the patchset for SEAD-3 is the correct one.

-Steve


<Prev in Thread] Current Thread [Next in Thread>