linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled

To: Markos Chandras <markos.chandras@imgtec.com>, USB list <linux-usb@vger.kernel.org>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
From: David Daney <ddaney.cavm@gmail.com>
Date: Thu, 13 Jun 2013 09:41:24 -0700
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=qVdQd5l7s17yw9HbGBtWn57VO2SXKCT4Eyqb/DPNDXo=; b=g/oUZCGNqPrBqifwmh2dIK6ltADyBkq7o1zm0wGPFR/D4gUGKlrXmYTlvWL0Dg7ED3 p24/3XldaWmdw13aqXnP9jsDyMYhO7764OTQxC5Q8it9HRdx2ijhZKPXxH+++4e6+5N2 qvjKsDOl/ESp1oKgREBjn37a9RuoCIeQhY0hVSHWDumDYI1+dW2loNYZ2fiLHTXtTTt/ spd+4KoSCqX/k7RdYSqmrBL3IAzXY+9JrJE23AcfzOQuoaG8ZGQ6r5eLtocpSZext5jL 76dJBCxzS7mNE9EGcMnMgNCYDH01NW+RfnbmfNdFDtNV6FpalcD4Jbk9dtnsZXZsqI+V Gv3w==
In-reply-to: <1371138134-21216-1-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371138134-21216-1-git-send-email-markos.chandras@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
On 06/13/2013 08:42 AM, Markos Chandras wrote:
Commit 94d83649e1c2f25c87dc4ead9c2ab073305
"USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol"

caused the following regression in cavium_octeon_defconfig:

warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
(USB_SUPPORT && USB && USB_EHCI_HCD)

We fix this problem by selecting the USB_EHCI_HCD missing dependency
if USB_SUPPORT is enabled.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>

NAK.  This is incorrect.

It is completely backwards and forces us to have EHCI unconditionally.

The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other Kconifg variables) out of the conditional section and make them universally visible/usable.

David Daney


---
This patch is for the upstream-sfr/mips-for-linux-next
---
  arch/mips/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 87ddac9..a058ba8 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1411,6 +1411,7 @@ config CPU_CAVIUM_OCTEON
        select CPU_SUPPORTS_HUGEPAGES
        select LIBFDT
        select USE_OF
+       select USB_EHCI_HCD if USB_SUPPORT
        select USB_EHCI_BIG_ENDIAN_MMIO
        help
          The Cavium Octeon processor is a highly integrated chip containing



<Prev in Thread] Current Thread [Next in Thread>