linux-mips
[Top] [All Lists]

Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet
From: Maxime Bizon <mbizon@freebox.fr>
Date: Thu, 13 Jun 2013 16:24:07 +0200
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org, ralf@linux-mips.org, John Crispin <blogic@openwrt.org>, Linux-MIPS <linux-mips@linux-mips.org>, jogo@openwrt.org, Kevin Cernekee <cernekee@gmail.com>
In-reply-to: <CAGVrzcaqbdLPcuL0m56aBLuG9ruaQ1p4JfTWZV9DJ4zSrNcXtg@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Freebox
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371066785-17168-1-git-send-email-florian@openwrt.org> <20130613.014450.1434692343011842828.davem@davemloft.net> <CAGVrzcYE4VDWtL_Uj1DrkZ6GqX6ghqPAXPpyLptc6PGwReixSQ@mail.gmail.com> <20130613.022524.568792627006552244.davem@davemloft.net> <CAGVrzcaqbdLPcuL0m56aBLuG9ruaQ1p4JfTWZV9DJ4zSrNcXtg@mail.gmail.com>
Reply-to: mbizon@freebox.fr
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2013-06-13 at 10:49 +0100, Florian Fainelli wrote:

> We are in the slow process to switch to Device Tree to precisely
> eliminate all of this (although not everyone agrees yet on the
> details). Hopefully you should not see such things in the future.

I don't see how DT help here (hint: it never does)

if the driver knows at compile time how registers are shuffled, it can
remove the indirection

if you use runtime cpu detection or DT, it cannot

in fact, this patch already adds another layer of indirection with that
"dma_chan_width" thing that the compiler has no way to optimize out,
defeating the purpose of single SOC optimization.

so we might as well force multi SOC support

-- 
Maxime



<Prev in Thread] Current Thread [Next in Thread>