linux-mips
[Top] [All Lists]

Re: [PATCH v2 3/6] dma: Add a jz4740 dmaengine driver

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2 3/6] dma: Add a jz4740 dmaengine driver
From: Vinod Koul <vinod.koul@intel.com>
Date: Wed, 12 Jun 2013 11:08:10 +0530
Cc: Ralf Baechle <ralf@linux-mips.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Maarten ter Huurne <maarten@treewalker.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
In-reply-to: <51B60D0A.7040307@metafoo.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369931105-28065-1-git-send-email-lars@metafoo.de> <1369931105-28065-4-git-send-email-lars@metafoo.de> <20130530171225.GA3767@intel.com> <51A79E8F.4070209@metafoo.de> <51B60D0A.7040307@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jun 10, 2013 at 07:29:46PM +0200, Lars-Peter Clausen wrote:
> On 05/30/2013 08:46 PM, Lars-Peter Clausen wrote:
> >>> +static int jz4740_dma_alloc_chan_resources(struct dma_chan *c)
> >>> +{
> >>> + struct jz4740_dmaengine_chan *chan = to_jz4740_dma_chan(c);
> >>> +
> >>> + chan->jz_chan = jz4740_dma_request(chan, NULL);
> >>> + if (!chan->jz_chan)
> >>> +         return -EBUSY;
> >>> +
> >>> + jz4740_dma_set_complete_cb(chan->jz_chan, jz4740_dma_complete_cb);
> >>> +
> >>> + return 0;
> >> Sorry, I didnt reply on this one. The API expects you to allocate a pool of
> >> descriptors. These descriptors are to be used in .device_prep_xxx calls 
> >> later.
> > 
> > The size of the descriptor is not fixed, so they can not be pre-allocated. 
> > And
> > this is nothing new either, most of the more recently added dmaengine 
> > drivers
> > allocate their descriptors on demand.
> 
> Vinod, are you ok with this explanation?
Sorry, I was travelling...

Can you explain more of a bit when you say size is not fixed. Why would it be
issue if we allocate descriptors at the alloc_chan. The idea is that you 
preallocated pool at alloc_chan and since the .device_prep_xxx calls can be
called from atomic context as well, you dont need to do this later. You can use 
use
these descriptors at that time. The idea is keep rotating the descriptors from
free poll to used one

--
~Vinod

<Prev in Thread] Current Thread [Next in Thread>