linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 10 Jun 2013 18:21:01 +0200
Cc: linux-mips@linux-mips.org, "Steven J. Hill" <Steven.Hill@imgtec.com>
In-reply-to: <1370864126-24931-1-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370864126-24931-1-git-send-email-markos.chandras@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 10, 2013 at 12:35:26PM +0100, Markos Chandras wrote:

> arch_ftrace_update_code and ftrace_modify_all_code are only
> available if CONFIG_DYNAMIC_FTRACE is selected.
> 
> Fixes the following build problem on MIPS randconfig:
> 
> arch/mips/kernel/ftrace.c: In function 'arch_ftrace_update_code':
> arch/mips/kernel/ftrace.c:31:2: error: implicit declaration of function
> 'ftrace_modify_all_code' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>

Patch is looking ok but I'm wonder abou thte SoB headers.  Since you
appear to be the patch author and are sending your own patch, one would
only expect your own SoB.  So I assume Steve's SoB was really meant to be
an Acked-by:?  Sam ealso for the other patch I accepted moments ago.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>