linux-mips
[Top] [All Lists]

Re: [PATCH v5 5/6] mips/kvm: Fix ABI by moving manipulation of CP0 regis

To: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v5 5/6] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_ONE_REG
From: David Daney <david.s.daney@gmail.com>
Date: Sun, 09 Jun 2013 15:57:55 -0700
Cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org, ralf@linux-mips.org, kvm@vger.kernel.org, Sanjay Lal <sanjayl@kymasys.com>, linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=w3QGc1fGqhcrmVrG7DoW2msDaRZ8H839dHk+tu3kOiI=; b=XuLIpRiUpzq7k7UD812x9EvMANDyP3JelkQu9FdOcOoXaesUP8xzhKkwVc+d3m9+y8 XTZRzsTf9BwP5U3jy2daX1dfpTB/mkmHqorHkJf41fyjpYA0ks7qkUGSluWdBV+S10Vo 3Z5JbpMT4iWL7y44j9fS+u8D9T0GNR5a/fvSDWj2555nbLk9zbo6VeN98v/se8ei+cf4 ZYW37CJB0qX3fOIhSUWDwfp7SPnaKIzhr5ajAyEbSQQ8GBMzyk7XKdxhjgop7t1CuCv7 3q5r8GdG2Ge0AerR5V/h15ATD6et54IQQ1vg9FLaLpi2f+U7BOJuiRU4VQG+AAx+dNt5 aDgQ==
In-reply-to: <20130608110503.GF15299@redhat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369248236-27237-1-git-send-email-ddaney.cavm@gmail.com> <1369248236-27237-6-git-send-email-ddaney.cavm@gmail.com> <20130608110503.GF15299@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 06/08/2013 04:05 AM, Gleb Natapov wrote:
On Wed, May 22, 2013 at 11:43:55AM -0700, David Daney wrote:
From: David Daney <david.daney@cavium.com>

Because not all 256 CP0 registers are ever implemented, we need a
different method of manipulating them.  Use the
KVM_SET_ONE_REG/KVM_GET_ONE_REG mechanism.

Now unused code and definitions are removed.

Just noticed that KVM_REG_MIPS_ definitions are wrong. You need to
define KVM_REG_MIPS in include/uapi/linux/kvm.h (please use
0x7000000000000000ULL as 0x6000000000000000ULL is reserved for ARM64)
and define all KVM_REG_MIPS_ values as "KVM_REG_MIPS | value". Can you
send a patch to do that ASAP?

It will have to be tomorrow, I cannot test anything today.

Thanks,
David Daney


<Prev in Thread] Current Thread [Next in Thread>