linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c

To: Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sat, 8 Jun 2013 19:54:30 +0100 (BST)
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1369909215.23034.39.camel@x61.thuisdomein>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369909215.23034.39.camel@x61.thuisdomein>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Thu, 30 May 2013, Paul Bolle wrote:

> promcon.o is built if CONFIG_PROM_CONSOLE is set. But there's no Kconfig
> symbol PROM_CONSOLE, so promcon.c is unbuildable. Remove it.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested.
> 
> 1) There used to be a Kconfig symbol PROM_CONSOLE. But it was SPARC
> specific and it was removed in v2.6.32, see commit 09d3f3f0e0 ("sparc:
> Kill PROM console driver.").
> 
> 2) Actually, it seems that it has never been possible to set
> PROM_CONSOLE for MIPS ever since this file was added in v2.3.9. I guess
> no-one noticed because (what seems to be) comparable functionality is
> provided in arch/mips/dec/prom/console.c.

 Yeah, I think over the years the file mostly served documentation 
purposes.  Given that we've had (as you also noticed) a working early-boot 
console available:

Acked-by: Maciej W. Rozycki <macro@linux-mips.org>

 Thanks for this clean-up.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c, Maciej W. Rozycki <=