linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier
From: John Crispin <blogic@openwrt.org>
Date: Thu, 06 Jun 2013 18:07:42 +0200
Cc: ralf@linux-mips.org, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <CAGVrzcYkYQjGyo9CWPsOMTkf3QwCfisBk_G_k51bB=6Unj2mRQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370526953-17122-1-git-send-email-blogic@openwrt.org> <CAGVrzcYkYQjGyo9CWPsOMTkf3QwCfisBk_G_k51bB=6Unj2mRQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 06/06/13 16:27, Florian Fainelli wrote:
2013/6/6 John Crispin<blogic@openwrt.org>:
On RT5350 the memory size is set to Bytes and not MegaBytes due to a missing
multiplier.
You might want to mention that the regression got introduced in
dd63b008 ("MIPS: ralink: make use of the new memory detection code").
This also needs to be in a future 3.10-rc pull request to Linus.

Cheers

Hi Florian

correct !

i mailed it as ralf is preparing a 3.10-rc pull request and i wanted this to make it ....

i will ping ralf on irc and ask him to fold the "dd63b008 ("MIPS: ralink: make use of the new memory detection code")." bit into the comment

Thanks,
    John

<Prev in Thread] Current Thread [Next in Thread>