linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 6 Jun 2013 15:27:29 +0100
Cc: ralf@linux-mips.org, Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=wy2F0HM4ygmEgBqqXMX9fmQE6DOeCDmTUV4q3nhz8DM=; b=I21kxRWI3MCyeaQysP4E1nAleOoub1Q6JU8Q+huhdKW5kYVskg9rRWn/0yCbQXiQIE 21jfwZo5KWSAP53Cac7rMNjuRbkpiduAI3vbSd6R0hh3tSLrSauHuxLIzFkO75YN5K1z u7N8Wpre9Wqex53ot1aJNG3MVObyx0TNtCQJI4S8bWlcUUSALIIA35WCq00HltzZFhRe XSON6z4rGdMOaQAuJ6gw87hS6cXqWCdwPsJ8Hj4wofDSNZ6WW9bWLGFM9BcLyiff7fG6 iMtNtM7h5bUoyJcXJaAGSPbbNp+/j2gCu7d0PJQe6IXxO/hnWw2wJPhc5T7x5I27kkvA 86iw==
In-reply-to: <1370526953-17122-1-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370526953-17122-1-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
2013/6/6 John Crispin <blogic@openwrt.org>:
> On RT5350 the memory size is set to Bytes and not MegaBytes due to a missing
> multiplier.

You might want to mention that the regression got introduced in
dd63b008 ("MIPS: ralink: make use of the new memory detection code").
This also needs to be in a future 3.10-rc pull request to Linus.

Cheers
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>  arch/mips/ralink/of.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
> index f916774..b25c1f2 100644
> --- a/arch/mips/ralink/of.c
> +++ b/arch/mips/ralink/of.c
> @@ -88,7 +88,7 @@ void __init plat_mem_setup(void)
>         __dt_setup_arch(&__dtb_start);
>
>         if (soc_info.mem_size)
> -               add_memory_region(soc_info.mem_base, soc_info.mem_size,
> +               add_memory_region(soc_info.mem_base, soc_info.mem_size * 
> SZ_1M,
>                                   BOOT_MEM_RAM);
>         else
>                 detect_memory_region(soc_info.mem_base,
> --
> 1.7.10.4
>
>

<Prev in Thread] Current Thread [Next in Thread>