linux-mips
[Top] [All Lists]

Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception

To: Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
Date: Wed, 5 Jun 2013 16:36:28 -0500
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>
In-reply-to: <CAOiHx=mFqC=GN0jmb9PXpt+JapfWoP3Pu5NM0sp=F_uAZuwUEA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370461798-20296-1-git-send-email-Steven.Hill@imgtec.com> <51AFA540.5010207@gmail.com> <51AFAA8C.6080002@imgtec.com> <CAOiHx=mFqC=GN0jmb9PXpt+JapfWoP3Pu5NM0sp=F_uAZuwUEA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
On 06/05/2013 04:23 PM, Jonas Gorski wrote:

        if (cpu_has_mmips) {
                unsigned int config3 = read_c0_config3();

                if (IS_ENABLED(CONFIG_CPU_MICROMIPS))
                        write_c0_config3(config3 | MIPS_CONF3_ISA_OE);
                else
                        write_c0_config3(config3 & ~MIPS_CONF3_ISA_OE);
        }


I like this being in 'trap_init' instead. Any objections?



<Prev in Thread] Current Thread [Next in Thread>