linux-mips
[Top] [All Lists]

Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Thu, 06 Jun 2013 01:30:50 +0400
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <51AFA879.1010009@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Cogent Embedded
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370461798-20296-1-git-send-email-Steven.Hill@imgtec.com> <51AF9923.7000606@cogentembedded.com> <51AFA879.1010009@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 06/06/2013 01:07 AM, David Daney wrote:
On 06/05/2013 01:01 PM, Sergei Shtylyov wrote:
Hello.

On 06/05/2013 11:49 PM, Steven J. Hill wrote:

The ISA exception bit selects whether exceptions are taken in classic
or microMIPS mode. This bit is Config3.ISAOnExc and was improperly
defined as bits 16 and 17 instead of just bit 16. A new function was
added so that platforms could set this bit when running a kernel
compiled with only microMIPS instructions.

     Ahem, isn't that function a material for another patch?


I think you might be going overboard. The entire patch relates to exactly one bit a config register, can't you let it be a single patch?

The purpose of the patch declared in its subject is just to fix the bit itself. Instead the patch does zillion other things, which IMHO not even always can be
considered fixes, so no, I'm not feeling like I'm going overboard with this.

David Daney

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>