linux-mips
[Top] [All Lists]

Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception bit.
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 05 Jun 2013 12:12:46 -0700
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6Lai5vzuRgAiAapzPfIJbRbMlFy9R1ZFJfczT/J1Gm0=; b=f19DkHcZeDx0wYWw8mvTdyaANEfJIim/Y3MQJbZNbtn6ulQbrIXVYoguti4wghNRRU sY2EgTEy0BimXnSeJsDF5ITw2gdnsxbXtPKh3xSIimWIx+gGMU59pal7J1Sospm4iSRB VaU7tqmuN5ncePariH618TBmg//9JQzW5d3mdTjROtRjFa7HCBY0Axg8mki87dwh6GxP 2b7prCevbmleR/7medsHtq0xIdkoUAvRH55eWaze+b+EJZqfRMzSZFBV1aesTwPSIPCO HnZSrwEdHH6wtYnuFq0iAgtJRiOhkVSlbWd6yrKGD3k9Ziqx/KVbQ2k61zfNa8THfgS4 qHnA==
In-reply-to: <alpine.LFD.2.03.1306052004030.15274@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com> <alpine.LFD.2.03.1306052004030.15274@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 06/05/2013 12:08 PM, Maciej W. Rozycki wrote:
On Wed, 5 Jun 2013, Steven J. Hill wrote:

diff --git a/arch/mips/mti-malta/malta-init.c b/arch/mips/mti-malta/malta-init.c
index ff8caff..76e0205 100644
--- a/arch/mips/mti-malta/malta-init.c
+++ b/arch/mips/mti-malta/malta-init.c
@@ -106,6 +106,8 @@ extern struct plat_smp_ops msmtc_smp_ops;

  void __init prom_init(void)
  {
+       set_micromips_exception_mode();
+
        mips_display_message("LINUX");

        /*
diff --git a/arch/mips/mti-sead3/sead3-init.c b/arch/mips/mti-sead3/sead3-init.c
index bfbd17b..9e314cb 100644
--- a/arch/mips/mti-sead3/sead3-init.c
+++ b/arch/mips/mti-sead3/sead3-init.c
@@ -130,6 +130,8 @@ static void __init mips_ejtag_setup(void)

  void __init prom_init(void)
  {
+       set_micromips_exception_mode();
+
        board_nmi_handler_setup = mips_nmi_setup;
        board_ejtag_handler_setup = mips_ejtag_setup;

  Shouldn't this be in a generic place such as trap_init instead?


I think it is fine here. If it spreads to more systems, then factoring them out into trap_init might make sense. For now it doesn't seem like we should clutter up trap_init when there aren't many microMIPS systems in existence.

David Daney


   Maciej




<Prev in Thread] Current Thread [Next in Thread>