linux-mips
[Top] [All Lists]

Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception

To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Subject: Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception bit.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Wed, 5 Jun 2013 20:08:44 +0100 (BST)
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, ddaney.cavm@gmail.com
In-reply-to: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Wed, 5 Jun 2013, Steven J. Hill wrote:

> diff --git a/arch/mips/mti-malta/malta-init.c 
> b/arch/mips/mti-malta/malta-init.c
> index ff8caff..76e0205 100644
> --- a/arch/mips/mti-malta/malta-init.c
> +++ b/arch/mips/mti-malta/malta-init.c
> @@ -106,6 +106,8 @@ extern struct plat_smp_ops msmtc_smp_ops;
>  
>  void __init prom_init(void)
>  {
> +     set_micromips_exception_mode();
> +
>       mips_display_message("LINUX");
>  
>       /*
> diff --git a/arch/mips/mti-sead3/sead3-init.c 
> b/arch/mips/mti-sead3/sead3-init.c
> index bfbd17b..9e314cb 100644
> --- a/arch/mips/mti-sead3/sead3-init.c
> +++ b/arch/mips/mti-sead3/sead3-init.c
> @@ -130,6 +130,8 @@ static void __init mips_ejtag_setup(void)
>  
>  void __init prom_init(void)
>  {
> +     set_micromips_exception_mode();
> +
>       board_nmi_handler_setup = mips_nmi_setup;
>       board_ejtag_handler_setup = mips_ejtag_setup;

 Shouldn't this be in a generic place such as trap_init instead?

  Maciej

<Prev in Thread] Current Thread [Next in Thread>