linux-mips
[Top] [All Lists]

Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception

To: "Steven J. Hill" <Steven.Hill@imgtec.com>, ralf@linux-mips.org
Subject: Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception bit.
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 05 Jun 2013 11:20:58 -0700
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ThZVORba/11h8vXSsNXuALI8mK4t1DCxQE6dWi+8cnY=; b=uJz9MS1hY6+0YsbpOAFiflonUN3f+pp86KnO9muJoGvUxFVuWlSrDjVgy6JQqPXJIU D7CrpsXLgpbcWk8skMKVF/0VsezVIqzqd29Z19KG/EA+V8WRxFbYYtrFhTYbt6n801ec d6FLN6S4yViRCKZU3vQxui024wjxMClprA+bPoCMt6DDjV5crw/e/OEnyTyfmPp85JLt Mrf1+yEd8xYcENq0728mJzOWJZY5EIud8SVeZkd8Lf+ccjhHQfvN2QTijkcY8Ue3D/GC sfh/194/D1QqjdWqkm7TcEYlPv5jLc72hZvSw+RK27NK1mvchcDnKh88MaoL86MrXXqa F+6w==
In-reply-to: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 06/05/2013 11:05 AM, Steven J. Hill wrote:
The ISA exception bit selects whether exceptions are taken in classic
or microMIPS mode. This bit is Config3.ISAOnExc and was improperly
defined as bits 16 and 17 instead of just bit 16. A new function was
added so that platforms could set this bit when running a kernel
compiled with only microMIPS instructions.

Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>

This looks good now,
Acked-by: David Daney <david.daney@cavium.com>

---
Changes in v4:
* Removed code from 'cpu-probe.c' and added new inline function to
   set exception mode.
* Reworded and simplified commit message.

  arch/mips/include/asm/mipsregs.h |   17 ++++++++++++++++-
  arch/mips/kernel/cpu-probe.c     |    3 ---
  arch/mips/mti-malta/malta-init.c |    2 ++
  arch/mips/mti-sead3/sead3-init.c |    2 ++
  4 files changed, 20 insertions(+), 4 deletions(-)



<Prev in Thread] Current Thread [Next in Thread>