linux-mips
[Top] [All Lists]

Re: [PATCH 06/18] KVM/MIPS32-VZ: VZ-ASE related callbacks to handle gues

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH 06/18] KVM/MIPS32-VZ: VZ-ASE related callbacks to handle guest exceptions that trap to the Root context.
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 30 May 2013 22:11:31 +0200
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Gleb Natapov <gleb@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=d7deQiimkzlFIfd1eB/+8DQ7HvcIVJ0GeCes6a5I0E0=; b=Ll97P66ff794GNFlhTp6kxdlZv347uSnNiG8mq82dKA/lnP4qg9m93Ki10cnLKBrp+ uk/yuObs8RtU+fRxo0ILapIFgZMFlUHISKJOKUYDv4+9lhsKrkrvtOhVfDCnszZTUGBD ydl3uCoSbDGfJ/Biy/yIJqQrc/n0Z//AWPWXRZ4ARTZW2r92mnCE/YXRTWY/J0TZysZy nmQ1M9esstutj0TiVw5qrjyjRKtqg9IwVtSZqUKWjWL3H3C8+riytksRJCP51u2y2Cn1 hGsztTB/WM7gq8CkruU0BxJe4WGKgLT1lrWtAPxmNzWYtfMdDsFF+fTqn0ORYw3IkPHm 2bZA==
In-reply-to: <2F16EB10-AFB8-4922-BAC1-EDCED4CC540E@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <n> <1368942460-15577-1-git-send-email-sanjayl@kymasys.com> <1368942460-15577-7-git-send-email-sanjayl@kymasys.com> <51A4D7F8.3060300@redhat.com> <2F16EB10-AFB8-4922-BAC1-EDCED4CC540E@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
Il 30/05/2013 20:35, Sanjay Lal ha scritto:
>>> >> +#endif
>>> >> +                local_irq_save(flags);
>>> >> +                if (kvm_mips_handle_vz_root_tlb_fault(badvaddr, vcpu) < 
>>> >> 0) {
>>> >> +                        run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
>>> >> +                        er = EMULATE_FAIL;
>>> >> +                }
>>> >> +                local_irq_restore(flags);
>>> >> +        }
>> > 
>> > This is introduced much later.  Please make sure that, with
>> > CONFIG_KVM_MIPS_VZ, every patch builds.
>> > 
>> > Paolo
>> > 
> Again, I think this has to do with the fact that the patches were
> against 3.10-rc2, will rebase for v2.

No, this is a simple patch ordering problem.
kvm_mips_handle_vz_root_tlb_fault is added in patch 11 only.

Paolo

<Prev in Thread] Current Thread [Next in Thread>