linux-mips
[Top] [All Lists]

Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)

To: James Hogan <james.hogan@imgtec.com>
Subject: Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 29 May 2013 10:19:32 -0700
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Al Viro <viro@zeniv.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Kees Cook <keescook@chromium.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=DqNdopBX7P/sLKx3ImUv26B035cHsY1opiPMQSu7DZM=; b=l1c3UwrNyGIMBgiRcMJNpGJ5fMgMYg8/PCZdeYzsHmkTNVeVdmZG32ZMjs9Tjk81Iy KYpZGXiqi1/q4vAR2PUvOQlFUSELadU69ODtL9uUtjwwep4pnLxTymfxzg0N+WhEjnyI +kb4UJX/XeiTFHQSnKEfwg21B8uapQBo4ay5DdC0DkVsYL5/+ftRLNoZMNBC93MvGsM2 ye757xfTX6iuj8DBcjG5CKc3UP5fjJ9Y/CpvqlhsuXitSQzSe70ivVwCde3SnMOUeMEQ UQC/ja1En1l+CCsrbStiJW4ok6yLsioybn9+x91ITwZwhiCuq8WzWdkkCDd+wPXgVtFw rfaQ==
In-reply-to: <1369846916-13202-1-git-send-email-james.hogan@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369846916-13202-1-git-send-email-james.hogan@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/29/2013 10:01 AM, James Hogan wrote:
MIPS has 128 signals, the highest of which has the number 128. The

I wonder if we should change the ABI and reduce the number of signals to 127 instead of this patch.

David Daney



following command causes get_signal_to_deliver() to pass this signal
number straight through to do_group_exit() as the exit code:

   strace sleep 10 & sleep 1 && kill -128 `pidof sleep`

However do_group_exit() checks for the core dump bit (0x80) in the exit
code which matches in this particular case and the kernel panics:

   BUG_ON(exit_code & 0x80); /* core dumps don't get here */

This is worked around by changing get_signal_to_deliver() to pass
min(info->si_signo, 127) instead of info->si_signo, so that this highest
of signal numbers get rounded down to 127. This makes the exit code
technically incorrect, but it's better than killing the whole kernel.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
---

This is based on v3.10-rc3.

It's a little hacky, but aside from reducing the number of signals to
127 to avoid this case (which isn't backwards compatible) I'm not sure
what else can be done. Any comments?

  kernel/signal.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 113411b..69bc00f 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2366,8 +2366,12 @@ relock:

                /*
                 * Death signals, no core dump.
+                *
+                * MIPS has a signal number 128 which clashes with the core dump
+                * bit. If this was the signal we still want to report a valid
+                * exit code, so round it down to 127.
                 */
-               do_group_exit(info->si_signo);
+               do_group_exit(min(info->si_signo, 127));
                /* NOTREACHED */
        }
        spin_unlock_irq(&sighand->siglock);



<Prev in Thread] Current Thread [Next in Thread>