linux-mips
[Top] [All Lists]

Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
From: Chen Gang <gang.chen@asianux.com>
Date: Wed, 29 May 2013 09:29:37 +0800
Cc: linux-mips@linux-mips.org
In-reply-to: <51A4A33E.3000605@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <51A1BF15.7070905@asianux.com> <51A4A33E.3000605@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
On 05/28/2013 08:29 PM, John Crispin wrote:
> On 26/05/13 09:51, Chen Gang wrote:
>> 'compatible' is used by strlen() in __of_device_is_compatible().
>>
>> So for NUL terminated string, need always be sure of ended by zero.
>>
>> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
>> all bytes, just use strlcpy() instead of strncpy().
>>
>>
>> Signed-off-by: Chen Gang<gang.chen@asianux.com>
> 
> Acked-by: John Crispin <blogic@openwrt.org>


Thanks.

-- 
Chen Gang

Asianux Corporation

<Prev in Thread] Current Thread [Next in Thread>