linux-mips
[Top] [All Lists]

Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()

To: Chen Gang <gang.chen@asianux.com>
Subject: Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
From: John Crispin <blogic@openwrt.org>
Date: Tue, 28 May 2013 14:29:50 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <51A1BF15.7070905@asianux.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <51A1BF15.7070905@asianux.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 26/05/13 09:51, Chen Gang wrote:
'compatible' is used by strlen() in __of_device_is_compatible().

So for NUL terminated string, need always be sure of ended by zero.

'of_ids' is not a structure in "include/uapi/*", so not need initialize
all bytes, just use strlcpy() instead of strncpy().


Signed-off-by: Chen Gang<gang.chen@asianux.com>

Acked-by: John Crispin <blogic@openwrt.org>

---
  arch/mips/lantiq/prom.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
index 9f9e875..49c4603 100644
--- a/arch/mips/lantiq/prom.c
+++ b/arch/mips/lantiq/prom.c
@@ -112,7 +112,7 @@ int __init plat_of_setup(void)
        if (!of_have_populated_dt())
                panic("device tree not present");

-       strncpy(of_ids[0].compatible, soc_info.compatible,
+       strlcpy(of_ids[0].compatible, soc_info.compatible,
                sizeof(of_ids[0].compatible));
        strncpy(of_ids[1].compatible, "simple-bus",
                sizeof(of_ids[1].compatible));


<Prev in Thread] Current Thread [Next in Thread>