linux-mips
[Top] [All Lists]

Re: [PATCH v3 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum

To: Tony Wu <tung7970@gmail.com>
Subject: Re: [PATCH v3 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 27 May 2013 13:32:03 +0100 (BST)
Cc: Ralf Baechle <ralf@linux-mips.org>, Steven.Hill@imgtec.com, david.daney@cavium.com, linux-mips@linux-mips.org
In-reply-to: <20130527105959.GB31548@hades>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130527105810.GA31548@hades> <20130527105959.GB31548@hades>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Mon, 27 May 2013, Tony Wu wrote:

> diff --git a/arch/mips/include/uapi/asm/inst.h 
> b/arch/mips/include/uapi/asm/inst.h
> index 0f4aec2..473a2ac 100644
> --- a/arch/mips/include/uapi/asm/inst.h
> +++ b/arch/mips/include/uapi/asm/inst.h
> @@ -409,10 +409,11 @@ enum mm_32f_73_minor_op {
>  enum mm_16c_minor_op {
>       mm_lwm16_op = 0x04,
>       mm_swm16_op = 0x05,
> -     mm_jr16_op = 0x18,
> -     mm_jrc_op = 0x1a,
> -     mm_jalr16_op = 0x1c,
> -     mm_jalrs16_op = 0x1e,
> +     mm_jr16_op = 0x0c,
> +     mm_jraddiusp_op = 0x18,
> +     mm_jrc_op = 0x0d,
> +     mm_jalr16_op = 0x1e,
> +     mm_jalrs16_op = 0x1f,
>  };

 Please keep these sorted by value, and also mm_jalr16_op and 
mm_jalrs16_op are wrong.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>