linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown bo

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 27 May 2013 14:19:03 +0400
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1369600543-21558-1-git-send-email-aaro.koskinen@iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369600543-21558-1-git-send-email-aaro.koskinen@iki.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
Hello.

On 27-05-2013 0:35, Aaro Koskinen wrote:

When booting a new board for the first time, the console is flooded with
"Unknown board" messages. This is not really helpful. Board type is not
going to change after the boot, so it's sufficient to print the warning
only once.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
  arch/mips/cavium-octeon/executive/cvmx-helper-board.c |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c 
b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
index 7c64977..e0451a0 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[...]
@@ -184,8 +186,7 @@ int cvmx_helper_board_get_mii_address(int ipd_port)
        }

        /* Some unknown board. Somebody forgot to update this function... */
-       cvmx_dprintf
-           ("cvmx_helper_board_get_mii_address: Unknown board type %d\n",
+       pr_warn_once("%s: Unknown board type %d\n", __func__,
             cvmx_sysinfo_get()->board_type);

   Please align this line under the next char under (.

WVR, Sergei


<Prev in Thread] Current Thread [Next in Thread>