linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: microMIPS: Refactor mips16 get_frame_info support

To: Tony Wu <tung7970@gmail.com>
Subject: Re: [PATCH v2] MIPS: microMIPS: Refactor mips16 get_frame_info support
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sun, 26 May 2013 09:46:10 +0100 (BST)
Cc: Ralf Baechle <ralf@linux-mips.org>, Steven.Hill@imgtec.com, linux-mips@linux-mips.org
In-reply-to: <alpine.LFD.2.03.1305252349290.18557@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130525163216.GA5956@hades> <alpine.LFD.2.03.1305252349290.18557@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Sun, 26 May 2013, Maciej W. Rozycki wrote:

>  I think this:
> 
> > +           return (((ip->u_format.uimmediate >> 6) & mm_jalr_op) == 
> > mm_jalr_op);
> 
> should be fully decoded (and oversize line fixed too):
> 
>               return (((ip->u_format.uimmediate >> 6) & ~0x14) == 
>                       mm_jalr_op);

 Self-correction here:

                return (((ip->u_format.uimmediate >> 6) & ~0x140) == 
                        mm_jalr_op);

-- sorry about the mistake.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>