linux-mips
[Top] [All Lists]

[PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()

To: ralf@linux-mips.org, blogic@openwrt.org, juhosg@openwrt.org
Subject: [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
From: Chen Gang <gang.chen@asianux.com>
Date: Sun, 26 May 2013 16:01:46 +0800
Cc: linux-mips@linux-mips.org, Linux-Arch <linux-arch@vger.kernel.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
'compatible' is used by strlen() in __of_device_is_compatible().

So for NUL terminated string, need always be sure of ended by zero.

'of_ids' is not a structure in "include/uapi/*", so not need initialize
all bytes, just use strlcpy() instead of strncpy().


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/mips/ralink/of.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
index fb15695..508f28f 100644
--- a/arch/mips/ralink/of.c
+++ b/arch/mips/ralink/of.c
@@ -104,7 +104,7 @@ static int __init plat_of_setup(void)
        if (!of_have_populated_dt())
                panic("device tree not present");
 
-       strncpy(of_ids[0].compatible, soc_info.compatible, len);
+       strlcpy(of_ids[0].compatible, soc_info.compatible, len);
        strncpy(of_ids[1].compatible, "palmbus", len);
 
        if (of_platform_populate(NULL, of_ids, NULL, NULL))
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>