linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: define cpu_has_mmips where appropriate

To: David Daney <ddaney.cavm@gmail.com>, Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH] MIPS: define cpu_has_mmips where appropriate
From: David Daney <ddaney.cavm@gmail.com>
Date: Fri, 24 May 2013 14:46:02 -0700
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Gabor Juhos <juhosg@openwrt.org>, "Steven J. Hill" <sjhill@mips.com>, David Daney <david.daney@cavium.com>, John Crispin <blogic@openwrt.org>, Lars-Peter Clausen <lars@metafoo.de>, Manuel Lauss <manuel.lauss@googlemail.com>, Huacai Chen <chenhc@lemote.com>, Jayachandran C <jchandra@broadcom.com>, Florian Fainelli <florian@openwrt.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6/ySs5TxwtXM51iii8TUlzL1Yv3KTCqYDCdYlJAOG3A=; b=NFuvYhgKE+WnKkk5m+FLfxUjMWlfx0NRhuwzWuFzIyJUSWZL0fIyALX9Apm1ftHZlH LMLYAHxmWYTePW0bWV93dXSkZtX0011TktDAlFnEGMwSYweC6TOZJUwfclPpG+cC4S2Q 3u2Ey/Hbv1Rdq2+dNVoD0J44AhQXv/tJunGYDAyXlxPf3wfw1EnMKzOFvE32WjDn6/cg OCqD9+RTqnI9g+qMjr75HXmym1x1ub/ftLVgTq3nUFnJshTveymbnQOEkGa+cj98+K+t STkjXDuD4jHnVCmRzaFAKfrj+6u0xUld5uBfvp/6FwTdcYtNDa7ojzYYLgxbb7jWmnO/ qjRQ==
In-reply-to: <519F933A.6020407@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369345335-28062-1-git-send-email-jogo@openwrt.org> <519F933A.6020407@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/24/2013 09:20 AM, David Daney wrote:
On 05/23/2013 02:42 PM, Jonas Gorski wrote:
Disable cpu_has_mmips for everything but SEAD3 and MALTA. Most of these
platforms are from before the micromips introduction, so they are very
unlikely to implement it.

Reduces an -Os compiled, uncompressed kernel image by 8KiB for BCM63XX.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>

Acked-by: David Daney <david.daney@cavium.com>

I changed my mind:  NAK.

I will send a smaller, but equivalent patch.


---

Position chosen is based on asm/cpu-features.h. Missing hardware and/or
data sheets for most platforms I obviously couldn't verify its
non-existence, so maintainer acks are appreciated.

  arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-rm/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h
|    1 +
  arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h
|    1 +
  21 files changed, 21 insertions(+)

[...]



<Prev in Thread] Current Thread [Next in Thread>