linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Trap exception handling fixes

To: "Maciej W. Rozycki" <macro@codesourcery.com>, "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH] MIPS: Trap exception handling fixes
From: David Daney <ddaney.cavm@gmail.com>
Date: Thu, 23 May 2013 10:00:37 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=cXvDha7krtc6p/bKBdVpFF3O1wzHakhZh3o2DvL23D4=; b=MThrJCmUPkoLEobIhefnEBZZUel1eLAtKYNuCdFim4Pgn6W/aMgd1T00A1leBR7DLQ qBKApiDgUnDsnQ+AAj93IbJG1YozDt41ocsO6/UMhBpVNBTz3oqAPpKT0OgQpfFslYv/ Vt+xK48DMKPEXk2hYVVxE1NVUKB6S57fPbV4tGWSnN2P7+NozBnnfdB2EtrPa+SNXHW+ d3rDvxX6rZ1kgCd7l4yd5FCAXcJnTjWwR1QUG9Snrq7QyCv+WgAPc6ECUNySmYfDgmoR dqK2/Uv+BRrA6JNyq0VSivIL3WvaCxYzpSWrIDR4+G/M/ANu3oN63swskHT19HXosUNR qlCA==
In-reply-to: <alpine.DEB.1.10.1305231744460.26443@tp.orcam.me.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.DEB.1.10.1305230253140.26443@tp.orcam.me.uk> <20130523155009.GA5598@linux-mips.org> <alpine.DEB.1.10.1305231656020.26443@tp.orcam.me.uk> <alpine.DEB.1.10.1305231744460.26443@tp.orcam.me.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/23/2013 09:54 AM, Maciej W. Rozycki wrote:
On Thu, 23 May 2013, Maciej W. Rozycki wrote:

It looks to me do_bp would benefit from some polishing too.

  To make myself more clear here -- there are two microMIPS BREAK encodings
of which do_bp assumes (without checking!) the 32-bit one, that is
actually unlikely to be ever present in compiler-generated code (so how
was this change validated?),

Probably sjhill should answer that, as they are his patches.

David Daney


and also the MIPS16 path is special-cased
(makes a separate call to do_trap_or_bp), which I find error-prone in
long-term maintenance.

   Maciej





<Prev in Thread] Current Thread [Next in Thread>