[Top] [All Lists]

Re: [PATCH] MIPS: Trap exception handling fixes

To: Ralf Baechle <>
Subject: Re: [PATCH] MIPS: Trap exception handling fixes
From: "Maciej W. Rozycki" <>
Date: Thu, 23 May 2013 17:54:24 +0100
Cc: <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Thu, 23 May 2013, Maciej W. Rozycki wrote:

> It looks to me do_bp would benefit from some polishing too.

 To make myself more clear here -- there are two microMIPS BREAK encodings 
of which do_bp assumes (without checking!) the 32-bit one, that is 
actually unlikely to be ever present in compiler-generated code (so how 
was this change validated?), and also the MIPS16 path is special-cased 
(makes a separate call to do_trap_or_bp), which I find error-prone in 
long-term maintenance.


<Prev in Thread] Current Thread [Next in Thread>