linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Trap exception handling fixes

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Trap exception handling fixes
From: "Maciej W. Rozycki" <macro@codesourcery.com>
Date: Thu, 23 May 2013 17:54:24 +0100
Cc: <linux-mips@linux-mips.org>
In-reply-to: <alpine.DEB.1.10.1305231656020.26443@tp.orcam.me.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.DEB.1.10.1305230253140.26443@tp.orcam.me.uk> <20130523155009.GA5598@linux-mips.org> <alpine.DEB.1.10.1305231656020.26443@tp.orcam.me.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Thu, 23 May 2013, Maciej W. Rozycki wrote:

> It looks to me do_bp would benefit from some polishing too.

 To make myself more clear here -- there are two microMIPS BREAK encodings 
of which do_bp assumes (without checking!) the 32-bit one, that is 
actually unlikely to be ever present in compiler-generated code (so how 
was this change validated?), and also the MIPS16 path is special-cased 
(makes a separate call to do_trap_or_bp), which I find error-prone in 
long-term maintenance.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>