linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Trap exception handling fixes

To: "Maciej W. Rozycki" <macro@codesourcery.com>
Subject: Re: [PATCH] MIPS: Trap exception handling fixes
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 23 May 2013 17:50:09 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <alpine.DEB.1.10.1305230253140.26443@tp.orcam.me.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.DEB.1.10.1305230253140.26443@tp.orcam.me.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, May 23, 2013 at 04:31:23PM +0100, Maciej W. Rozycki wrote:

> 2a0b24f56c2492b932f1aed617ae80fb23500d21 broke Trap exception handling in 
> the standard MIPS mode.  Additionally the microMIPS-mode trap code mask is 
> wrong, as it's a 4-bit field.  Here's a fix.
> 
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Ralf, please apply.  Also the mention of: "A few NOP instructions are used 
> to maintain the correct alignment[...]" in the commit referred makes me 
> feel scared -- there is that .align pseudo-op, you know...  Maciej

Thanks, applied.

Seems that whole bloody patchset was painfully unripe :-(

  Ralf

<Prev in Thread] Current Thread [Next in Thread>