linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD t

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 21 May 2013 15:07:23 -0700
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>, <ralf@linux-mips.org>, David Daney <david.daney@cavium.com>, <linux-ide@vger.kernel.org>, <linux-edac@vger.kernel.org>, <linux-i2c@vger.kernel.org>, <netdev@vger.kernel.org>, <spi-devel-general@lists.sourceforge.net>, <devel@driverdev.osuosl.org>, <linux-usb@vger.kernel.org>
In-reply-to: <20130521220457.GF31836@blackmetal.musicnaut.iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1369088378-13957-1-git-send-email-ddaney.cavm@gmail.com> <20130521220457.GF31836@blackmetal.musicnaut.iki.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/21/2013 03:04 PM, Aaro Koskinen wrote:
Hi,

What about OCTEON_WDT, should it be changed too:

         tristate "Cavium OCTEON SOC family Watchdog Timer"
         depends on CPU_CAVIUM_OCTEON

On Mon, May 20, 2013 at 03:19:38PM -0700, David Daney wrote:
  config OCTEON_MGMT_ETHERNET
        tristate "Octeon Management port ethernet driver (CN5XXX, CN6XXX)"
-       depends on  CPU_CAVIUM_OCTEON
+       depends on  CAVIUM_OCTEON_SOC

  config MDIO_OCTEON
        tristate "Support for MDIO buses on Octeon SOCs"
-       depends on  CPU_CAVIUM_OCTEON
+       depends on  CAVIUM_OCTEON_SOC

  config USB_OCTEON_OHCI
        bool "Octeon on-chip OHCI support"
-       depends on CPU_CAVIUM_OCTEON
+       depends on  CAVIUM_OCTEON_SOC

Just a minor comment, here the extra whitespace after "depends on"
could be eliminated.


Good point.  I will regenerate the patch to correct this.

Thanks,
David Daney




<Prev in Thread] Current Thread [Next in Thread>