linux-mips
[Top] [All Lists]

Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lo

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()
From: Gleb Natapov <gleb@redhat.com>
Date: Tue, 21 May 2013 11:00:47 +0300
Cc: linux-mips@linux-mips.org, kvm@vger.kernel.org, ralf@linux-mips.org, mtosatti@redhat.com
In-reply-to: <AB98FD4C-123F-4C64-B6CF-0F86E4EBD554@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <n> <1368885266-8619-1-git-send-email-sanjayl@kymasys.com> <1368885266-8619-3-git-send-email-sanjayl@kymasys.com> <20130519125210.GI4725@redhat.com> <AB98FD4C-123F-4C64-B6CF-0F86E4EBD554@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
On Sun, May 19, 2013 at 10:36:32AM -0400, Sanjay Lal wrote:
> 
> On May 19, 2013, at 8:52 AM, Gleb Natapov wrote:
> 
> > On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote:
> >> - As suggested by Gleb, wrap calls to gfn_to_pfn() with 
> >> srcu_read_lock/unlock().
> >>  Memory slots should be acccessed from a SRCU read section.
> >> - kvm_mips_map_page() now returns an error code to it's callers, instead 
> >> of calling panic()
> >> if it cannot find a mapping for a particular gfn.
> >> 
> >> Signed-off-by: Sanjay Lal <sanjayl@kymasys.com>
> >> ---
> >> arch/mips/kvm/kvm_tlb.c | 36 +++++++++++++++++++++++++++---------
> >> 1 file changed, 27 insertions(+), 9 deletions(-)
> >> 
> >> diff --git a/arch/mips/kvm/kvm_tlb.c b/arch/mips/kvm/kvm_tlb.c
> >> index 89511a9..ab2e9b0 100644
> >> --- a/arch/mips/kvm/kvm_tlb.c
> >> +++ b/arch/mips/kvm/kvm_tlb.c
> >> @@ -16,7 +16,10 @@
> >> #include <linux/mm.h>
> >> #include <linux/delay.h>
> >> #include <linux/module.h>
> >> +#include <linux/bootmem.h>
> > You haven't answered it when I asked it on v2:
> > Is this include still needed now when export of min_low_pfn is not
> > longer here?
> > 
> 
> Sorry about that, juggling too many patches, bootmem.h is no longer needed in 
> kvm_tlb.c.  Actually, I thought I had removed it before posting v3.
> 
Should I expect new version, or can I just drop this include from the
patch and apply?

--
                        Gleb.

<Prev in Thread] Current Thread [Next in Thread>