linux-mips
[Top] [All Lists]

Re: [PATCH 00/18] KVM/MIPS32: Support for the new Virtualization ASE (VZ

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH 00/18] KVM/MIPS32: Support for the new Virtualization ASE (VZ-ASE)
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 20 May 2013 10:29:13 -0700
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Gleb Natapov <gleb@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=DZV5U2L5PHRIPNuV6P4znNknFbHD4eEv2Lu5IpgXvFg=; b=Xrgha8j64yy7qd0LoYB6m8z5ths5Aat1xY5bl2SFx57TpDUl9DJWN5jI/k//HlUzax tsx3aIc+MQQn2tmfawwO1LF+gCUlql8KUrGJwMPz257qa6qh9Pb+f9VfG8tWoWjpvrO7 RT9rRGdBZmNbwpEPjtOoeRLHQWuyJbeeKDfb36qaBoTd0QGKLzMpsAZnoL8eTHbc7t8H 4Pv7Dj4BlLXv/aEU1SDCjXnyAOSBSy8nMugrq0usyxV6wQPbGlofyLC55yArol+Zw79E oLa4ZepwVMoDmTIGYFwL/GjSrY9HhnQD7Bd1gCFMurexPjoH3wpp6FTjvlSuViLRwQZI 9hMQ==
In-reply-to: <456B70C6-A896-4B94-B8EF-DE6ED26CE859@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <n> <1368942460-15577-1-git-send-email-sanjayl@kymasys.com> <519A4640.6060202@gmail.com> <456B70C6-A896-4B94-B8EF-DE6ED26CE859@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/20/2013 09:58 AM, Sanjay Lal wrote:

On May 20, 2013, at 8:50 AM, David Daney wrote:

On 05/18/2013 10:47 PM, Sanjay Lal wrote:
The following patch set adds support for the recently announced virtualization
extensions for the MIPS32 architecture and allows running unmodified kernels in
Guest Mode.

For more info please refer to :
        MIPS Document #: MD00846
        Volume IV-i: Virtualization Module of the MIPS32 Architecture

which can be accessed @: 
http://www.mips.com/auth/MD00846-2B-VZMIPS32-AFP-01.03.pdf

The patch is agains Linux-3.10-rc1.

KVM/MIPS now supports 2 modes of operation:

(1) VZ mode: Unmodified kernels running in Guest Mode.  The processor now 
provides
     an almost complete COP0 context in Guest mode. This greatly reduces VM 
exits.

Two questions:

1) How are you handling not clobbering the Guest K0/K1 registers when a Root 
exception occurs?  It is not obvious to me from inspecting the code.

2) What environment are you using to test this stuff?

David Daney


(1) Newer versions of the MIPS architecture define scratch registers for just 
this purpose, but since we have to support standard MIPS32R2 processors, we use 
the DDataLo Register (CP0 Register 28, Select 3) as a scratch register to save 
k0 and save k1 @ a known offset from EBASE.


Right, I understand that. But I am looking at arch/mips/mm/tlbex.c, and I don't see the code that does that for TLBRefill exceptions.

Where is it done for interrupts? I would expect code in arch/mips/kernel/genex.S and/or stackframe.h would handle this. But I don't see where it is.

Am I missing something?

David Daney


<Prev in Thread] Current Thread [Next in Thread>