linux-mips
[Top] [All Lists]

Re: [PATCH v99,11/13] MIPS: microMIPS: Optimise 'strncpy' core library f

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v99,11/13] MIPS: microMIPS: Optimise 'strncpy' core library function.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sun, 19 May 2013 00:25:51 +0100 (BST)
Cc: "Steven J. Hill" <sjhill@realitydiluted.com>, linux-mips@linux-mips.org
In-reply-to: <518A7D40.1060502@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1354856737-28678-1-git-send-email-sjhill@mips.com> <1354856737-28678-12-git-send-email-sjhill@mips.com> <518987BD.7030900@gmail.com> <5189C41D.3000005@realitydiluted.com> <518A7D40.1060502@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Wed, 8 May 2013, David Daney wrote:

> > > You don't really explain how the change helps optimization either.
> > > 
> > The exercise is left to the reader. Build a microMIPS kernel yourself and
> > figure it out.
> 
> This isn't some sort of programming text book.  Your job in the change log
> (and the mailing list) isn't to force us to learn by doing a lot of
> independent analysis of the code.  Instead I would prefer a concise
> explanation of why the change is beneficial.
> 
> You are dumping a lot of new code into the kernel.  That is fine, but you
> could consider making the process easier by improving the quality of the
> changelogs  that accompany it.

 I concur, it's the contributor's responsibility to make the reviewers' 
work as easy as possible and to convince them that the change offered is 
both technically correct and desired for inclusion.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>