linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lo

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH 2/2] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 15 May 2013 09:54:24 -0700
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org, linux-mips@linux-mips.org, mtosatti@redhat.com, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=zh2H1qWk66SwHyZCH8ymY5mS+PsW6VEGiSnMMgpOa70=; b=YYJllalUIa+KZjc1SXgvgq8udGI8ukA5eXdFfEd1JQ6wjDJ/dejLT4bZ9bJtAxOBAD X4mcYpcVOQtQ2FdBnxY3+gdrNzIejIo1hxCKNi3HhHYPmjgwx2RUCtsQvjutSFYcIcLW Be3xw6ozsZJpAv+tU7opgoNFXJIlVgSaXkLSpZkp3ekPTRSWWqXoY6JhlrQpOHrbVvqo 0Q3o5+yiOu3OSw+DjwbqIdkWgNLRO/gxYc6MAicF98D+yPBV/w4cVgODaqkWUpQMC+JE 4EXZxEOOldhweYxiJJzgI00vr+qXjN2FTLs/BzcMgSbI9F9v70Gw6s8lSj7Gu8XT1PJG +VSw==
In-reply-to: <63B7D172-E75E-4AB4-8515-9A18360B66A2@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <n> <1368476500-20031-1-git-send-email-sanjayl@kymasys.com> <1368476500-20031-3-git-send-email-sanjayl@kymasys.com> <20130514092705.GD20995@redhat.com> <63B7D172-E75E-4AB4-8515-9A18360B66A2@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/15/2013 08:54 AM, Sanjay Lal wrote:

On May 14, 2013, at 2:27 AM, Gleb Natapov wrote:



+EXPORT_SYMBOL(min_low_pfn);     /* defined by bootmem.c, but not exported by 
generic code */
+
What you need this for? It is not used anywhere in this patch and by
mips/kvm code in general.

I did some digging around myself, since the linker keeps complaining that it 
can't find min_low_pfn when compiling the KVM module.  It seems that it is 
indirectly pulled in by the cache management functions.


If it is really needed, then the export should probably be done at the site of the min_low_pfn definition, not in some random architecture file.

An alternative is to fix the cache management functions so they don't require the export.

David Daney


Regards
Sanjay







<Prev in Thread] Current Thread [Next in Thread>