linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] MIPS: BCM63XX: export PSI size from nvram

To: Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH 2/3] MIPS: BCM63XX: export PSI size from nvram
From: Florian Fainelli <florian@openwrt.org>
Date: Sun, 12 May 2013 16:52:47 +0200
Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>, Maxime Bizon <mbizon@freebox.fr>, Kevin Cernekee <cernekee@gmail.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=rsfAjQaIDHVhSVOeFTO1uKKUVcYFjuNE1Hbrl3nqgpg=; b=w26iu/gBTXHBtXs9wFFkRgGeYObJwod4OF7Xmht6pUGt5P95Rr0LTJavhT+5VniD06 NJQY0ZhbyBwlyM03ycRP6aBcWk/GSuQ3/R0j7N+XYqioAjjmqLU0Sa+oZCw3nlyGWRLm 9JXJdh/DdevTVJRIydTpXPnLwWNL27XyKJuugEB+Vx+xy0EvmRmoiV0hFjkdT59cb9qr h1xXypzr4Bohthu72bqHCpk2W67PjAq79SCg45pzT093TMCESdoMKBKSijHmNr+MfUSX Wussf9bVMmnSLUU5QH0+aJF7A6w0A1282sDi4hcs1sdW8bukuMTvs3pYT1+CEfIn255c kSfQ==
In-reply-to: <CAOiHx=m+ZuBcj=qmTtytWouCbtbj+_OX3dS8x_0=kHEBFZ+TmA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1364044070-10486-1-git-send-email-jogo@openwrt.org> <1364044070-10486-3-git-send-email-jogo@openwrt.org> <1368189407.26780.159.camel@sauron.fi.intel.com> <CAOiHx=m+ZuBcj=qmTtytWouCbtbj+_OX3dS8x_0=kHEBFZ+TmA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
Le 12/05/2013 12:48, Jonas Gorski a écrit :
On Fri, May 10, 2013 at 2:36 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
On Sat, 2013-03-23 at 14:07 +0100, Jonas Gorski wrote:
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
---
  arch/mips/bcm63xx/nvram.c                          |   11 +++++++++++
  arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h |    2 ++
  2 files changed, 13 insertions(+)

Acks from MIPS folks would be nice to have, but I pushed this patch to
the l2-mtd.git tree, thanks!

I had expected Florian's valid comment from preventing this series
from going in, but if you pushed it already then I will fix the return
type problem  that Florian pointed out in a separate patch (or rather
add add some range check for nvram.psi_size). Luckily it is a
theoretical issue only, as I haven't seen a device yet with an invalid
value.

Right, but this is no blocker from my perspective. As about the MIPS folks, Maxime, Kevin, Jonas and myself have been the "historical" contributors to the MIPS BCM63XX port, so I would consider Jonas to be authoritave here for these paches. John and Ralf usually do not comment unless the see something bad.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>