linux-mips
[Top] [All Lists]

Re: [RFC 40/42] arch/mips/lantiq/xway: don't check resource with devm_io

To: Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [RFC 40/42] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
From: John Crispin <john@phrozen.org>
Date: Fri, 10 May 2013 10:57:37 +0200
Cc: linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1368173847-5661-41-git-send-email-wsa@the-dreams.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> <1368173847-5661-41-git-send-email-wsa@the-dreams.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 10/05/13 10:17, Wolfram Sang wrote:
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang<wsa@the-dreams.de>

Acked-by: John Crispin <blogic@openwrt.org>

---
  arch/mips/lantiq/xway/gptu.c |    7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c
index 9861c86..26226f0 100644
--- a/arch/mips/lantiq/xway/gptu.c
+++ b/arch/mips/lantiq/xway/gptu.c
@@ -143,13 +143,8 @@ static int gptu_probe(struct platform_device *pdev)
                return -EINVAL;
        }

-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "Failed to get resource\n");
-               return -ENOMEM;
-       }
-
        /* remap gptu register range */
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        gptu_membase = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(gptu_membase))
                return PTR_ERR(gptu_membase);


<Prev in Thread] Current Thread [Next in Thread>