linux-mips
[Top] [All Lists]

Re: [PATCH v99,11/13] MIPS: microMIPS: Optimise 'strncpy' core library f

To: linux-mips@linux-mips.org
Subject: Re: [PATCH v99,11/13] MIPS: microMIPS: Optimise 'strncpy' core library function.
From: "Steven J. Hill" <sjhill@realitydiluted.com>
Date: Tue, 07 May 2013 22:18:53 -0500
In-reply-to: <518987BD.7030900@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1354856737-28678-1-git-send-email-sjhill@mips.com> <1354856737-28678-12-git-send-email-sjhill@mips.com> <518987BD.7030900@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/07/2013 06:01 PM, David Daney wrote:
> On 12/06/2012 09:05 PM, Steven J. Hill wrote:
>> From: "Steven J. Hill" <sjhill@mips.com>
>> 
>> Optimise 'strncpy' to use microMIPS instructions and/or optimisations for
>> binary size reduction. When the microMIPS ISA is not being used, the
>> library function compiles to the original binary code.
> 
> This is an untrue statement.  Why mislead us by saying the original binary
> code is obtained?
> 
I you are building a classic MIPS kernel, the instructions generated will be
the same even with this patch. The changes only make a difference when
building a pure microMIPS kernel.

> You don't really explain how the change helps optimization either.
> 
The exercise is left to the reader. Build a microMIPS kernel yourself and
figure it out.

- -Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlGJxBcACgkQgyK5H2Ic36c4hQCeLGI8MI2rr6KgOv7G15lnBdok
bbcAoKY+BvVyTCzG033Bc+pJ07xCtGMq
=xJmM
-----END PGP SIGNATURE-----

<Prev in Thread] Current Thread [Next in Thread>