linux-mips
[Top] [All Lists]

Re: MIPS : die at free_initmem() function 3.9+

To: Jiang Liu <liuj97@gmail.com>, "ralf@linux-mips.org" <ralf@linux-mips.org>
Subject: Re: MIPS : die at free_initmem() function 3.9+
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 07 May 2013 10:27:16 -0700
Cc: eunb.song@samsung.com, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "jogo@openwrt.org" <jogo@openwrt.org>, "david.daney@cavium.com" <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4p3miqFaSk/H5mAO9rcgRflpRRqTHyG049wvhYBIr+E=; b=iZNiDOQgLIzVK6+7lBKxKXpE4y6akKVlSOrRlw1827Ge3sThZeZM8z4yn7uYytW8Vg 9128WYSWOlV1Qi66XxGvEjnrnteitPR9kZRMIJtZqMMMH2t/jROssJcORkT415NIrcly DstLX4br00gASO861NG/VLxTnnt69iCUmY5iw3dldubQ5XGY8RPsytuC256kCkR6ssGE JGo2kgJOHif6fdgNXGIh0u4Ipk6srbfa5ITWUtIQOqhndf2vuzDNWDVQEhjIQFOpxC7U Z6ZHNUuSoewB3LzTG04VV4OySYOYD4wLfjSov0fUsL4+tVnilOuzmXGZghutlpue9eu2 rrpw==
In-reply-to: <51892FF5.9020607@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <21534601.395241367793582818.JavaMail.weblogic@epv6ml08> <51892FF5.9020607@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
On 05/07/2013 09:46 AM, Jiang Liu wrote:
Hi Eunsong,
        Thanks for your help. I have done some code inspection and have
found a possible reason for this issue. It seems that virt_to_page()
can't be used to handle address in compatible segments due to following
definitions.

This has caused multiple problems in the past. I wrote a patch to correct this problem, but it looks like it was never applied.

I just sent the patch to you guys as a separate e-mail.

David Daney




#define virt_to_page(kaddr)     pfn_to_page(PFN_DOWN(virt_to_phys(kaddr)))
static inline unsigned long virt_to_phys(volatile const void *address)
{
         return (unsigned long)address - PAGE_OFFSET + PHYS_OFFSET;
}
#define __va(x)         ((void *)((unsigned long)(x) + PAGE_OFFSET - 
PHYS_OFFSET))
#define __pa_symbol(x)  __pa(RELOC_HIDE((unsigned long)(x), 0))
#define __pa(x)                                                         \
({                                                                      \
     unsigned long __x = (unsigned long)(x);                             \
     __x < CKSEG0 ? XPHYSADDR(__x) : CPHYSADDR(__x);                     \
})

#define CPHYSADDR(a)            ((_ACAST32_(a)) & 0x1fffffff)
#define XPHYSADDR(a)            ((_ACAST64_(a)) &                       \
                                  _CONST64_(0x000000ffffffffff))

#define XKUSEG                  _CONST64_(0x0000000000000000)
#define XKSSEG                  _CONST64_(0x4000000000000000)
#define XKPHYS                  _CONST64_(0x8000000000000000)
#define XKSEG                   _CONST64_(0xc000000000000000)
#define CKSEG0                  _CONST64_(0xffffffff80000000)
#define CKSEG1                  _CONST64_(0xffffffffa0000000)
#define CKSSEG                  _CONST64_(0xffffffffc0000000)
#define CKSEG3                  _CONST64_(0xffffffffe0000000)

So could you please help to prepare a formal patch for this bug and send
it to Andrew Morton for v3.10-rc1? Otherwise I could help to it too.

Regards!
Gerry


=On 05/06/2013 06:39 AM, EUNBONG SONG wrote:

So on 64bits MIPS platforms, __va(__pa(x)) may not equal to x, that may cause
trouble to free_initmem_default(). Could you please help to do another test
by changing
free_initmem_default(POISON_FREE_INITMEM);
to
free_initmem_default(0);

This test could help to identify whether this panic is caused by
memset((void *)pos, poison, PAGE_SIZE);
in function free_reserved_area().

Hello, as you said i changed  "free_initmem_default(POISON_FREE_INITMEM);" to
"free_initmem_default(0);". Panic still occurred.
Actually, i put the some debug messages. and i confirmed panic occurs in 
__free_reserved_page() function.
Thanks!

N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�&j:+v돣�쳭喩zZ+�+zf"톒쉱�~넮녬i�鎬z�췿ⅱ�?솳鈺�&�)刪f뷌^j푹y쬶끷@A첺뛴��
0띠h��i�


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/




<Prev in Thread] Current Thread [Next in Thread>