linux-mips
[Top] [All Lists]

Re: [PATCH] mips: Fix invalid interrupt name in cavium-octeon

To: EUNBONG SONG <eunb.song@samsung.com>, David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] mips: Fix invalid interrupt name in cavium-octeon
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 22 Apr 2013 15:22:03 +0200
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <2202498.1401366325451851.JavaMail.weblogic@epv6ml11>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <2202498.1401366325451851.JavaMail.weblogic@epv6ml11>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 18, 2013 at 10:50:52PM +0000, EUNBONG SONG wrote:

> Change interrupt name from "RML/RSL" to "RMLRSL".
> This fixes following warning message.
> 
> [   24.938793] WARNING: at fs/proc/generic.c:307 
> __xlate_proc_name+0x124/0x160()
> [   24.945926] name 'RML/RSL'
> [   24.948642] Modules linked in:
> [   24.951707] Call Trace:
> [   24.954157] [<ffffffff8069fe18>] dump_stack+0x8/0x34
> [   24.959136] [<ffffffff80290d90>] warn_slowpath_common+0x78/0xa8
> [   24.965056] [<ffffffff80290e60>] warn_slowpath_fmt+0x38/0x48
> [   24.970723] [<ffffffff803cbc8c>] __xlate_proc_name+0x124/0x160
> [   24.976556] [<ffffffff803cbe78>] __proc_create+0x78/0x128
> [   24.981963] [<ffffffff803cd044>] proc_mkdir_mode+0x2c/0x70
> [   24.987451] [<ffffffff80302418>] register_handler_proc+0x108/0x130
> [   24.993642] [<ffffffff802fd078>] __setup_irq+0x210/0x540
> [   24.998963] [<ffffffff802fd67c>] request_threaded_irq+0x114/0x1a0
> [   25.005060] [<ffffffff80262e0c>] prom_free_prom_memory+0xd4/0x588
> [   25.011164] [<ffffffff80691820>] free_initmem+0x10/0xc0
> [   25.016390] [<ffffffff80691720>] kernel_init+0x20/0x100
> [   25.021624] [<ffffffff8026c7e0>] ret_from_kernel_thread+0x10/0x18
> 
> Signed-off-by: Eunbong Song <eunb.song@samsung.com>
> ---
>  arch/mips/cavium-octeon/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index b0baa29..92c3150 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -1066,7 +1066,7 @@ void prom_free_prom_memory(void)
>  
>       /* Add an interrupt handler for general failures. */
>       if (request_irq(OCTEON_IRQ_RML, octeon_rlm_interrupt, IRQF_SHARED,
> -                     "RML/RSL", octeon_rlm_interrupt)) {
> +                     "RMLRSL", octeon_rlm_interrupt)) {
>               panic("Unable to request_irq(OCTEON_IRQ_RML)");
>       }
>  #endif

Interesting.  While your patch certainly is correct, you seem to have
further modifications in your tree.

David, Above code is wrapped by #ifdef CONFIG_CAVIUM_DECODE_RSL but doesn't
seem to get defined anywhere.  What shall we do about this?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>