linux-mips
[Top] [All Lists]

Re: [PATCH V2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency

To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH V2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
From: John Crispin <blogic@openwrt.org>
Date: Tue, 16 Apr 2013 18:11:08 +0200
Cc: Jonas Gorski <jogo@openwrt.org>, linux-serial@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <CAOiHx=npmzXe8yk1NLwzK0dQ-XsM-0bbT+L5Yg5LL05n0a3BKA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1366093125-19352-1-git-send-email-blogic@openwrt.org> <CAOiHx=npmzXe8yk1NLwzK0dQ-XsM-0bbT+L5Yg5LL05n0a3BKA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
This won't work, Having RALINK=y, but SERIAL_8250=n will still result
in SERIAL_8250_RT288X=y, as select ignores dependencies. What could
work is removing the select from RALINK, and changing the depends from
this one to "default y if SERIAL_8250&&  MIPS&&  RALINK".



ok, these tty patches were rushed too much. i think trying to get them ready quickly for 3.10 was a bad bad idea, that already wasted too much of other peoples time. instead of making even more of a fool of myself and wasting yet more time we should just drop it and i will try again with more time for 3.11.

Sorry for the noise :-)
    John

<Prev in Thread] Current Thread [Next in Thread>