[Top] [All Lists]

Re: [PATCH V2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency

To: Greg Kroah-Hartman <>
Subject: Re: [PATCH V2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
From: John Crispin <>
Date: Tue, 16 Apr 2013 18:11:08 +0200
Cc: Jonas Gorski <>,,
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
This won't work, Having RALINK=y, but SERIAL_8250=n will still result
in SERIAL_8250_RT288X=y, as select ignores dependencies. What could
work is removing the select from RALINK, and changing the depends from
this one to "default y if SERIAL_8250&&  MIPS&&  RALINK".

ok, these tty patches were rushed too much. i think trying to get them ready quickly for 3.10 was a bad bad idea, that already wasted too much of other peoples time. instead of making even more of a fool of myself and wasting yet more time we should just drop it and i will try again with more time for 3.11.

Sorry for the noise :-)

<Prev in Thread] Current Thread [Next in Thread>