linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Mon, 15 Apr 2013 21:08:30 -0700
Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=NIAfY6E6J+taeN6w9HuxiTo0Wu8fpAhts7KhL9G/Nko=; b=MJuilaAh4pRXnoa2oK8sqyeyYCYGQ/IATbSg41GATvRxxx/7mgNiQ8NH436s5eZ336 uSZUDLNCTi7u97pNzoNKh5aOIroLU4vDzkqOSyZWr/exSAL6y0M5fi/bABPemL4k873l bKDafqLUEbfZsxhPZwODEHzaX2qirarL6COgA=
In-reply-to: <516CCC26.5000504@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1365845973-16164-1-git-send-email-blogic@openwrt.org> <20130415181527.GA25341@kroah.com> <516CCC26.5000504@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 16, 2013 at 05:57:26AM +0200, John Crispin wrote:
> On 15/04/13 20:15, Greg Kroah-Hartman wrote:
> >On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote:
> >>With every Ralink SoC that we add, we would need to extend the dependency. 
> >>In
> >>order to make life easier we make the symbol depend on MIPS&  RALINK and 
> >>then
> >>select it from within arch/mips/ralink/.
> >>
> >>Signed-off-by: John Crispin<blogic@openwrt.org>
> >>---
> >>
> >>These 2 patches in this series should be merged via the mips tree. Patch 1/2
> >>requires an Ack from the tty maintainer.
> >>
> >>  drivers/tty/serial/8250/Kconfig |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/tty/serial/8250/Kconfig 
> >>b/drivers/tty/serial/8250/Kconfig
> >>index 80fe91e..24ea3c8 100644
> >>--- a/drivers/tty/serial/8250/Kconfig
> >>+++ b/drivers/tty/serial/8250/Kconfig
> >>@@ -295,8 +295,8 @@ config SERIAL_8250_EM
> >>      If unsure, say N.
> >>
> >>  config SERIAL_8250_RT288X
> >>-   bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
> >>-   depends on SERIAL_8250&&  (SOC_RT288X || SOC_RT305X || SOC_RT3883)
> >>+   bool
> >>+   depends on SERIAL_8250&&  MIPS&&  RALINK
> >
> >This patch doesn't create a select anywhere, so how can a user know what
> >to do here?
> >
> >greg k-h
> 
> Hi Greg,
> 
> The select happens in patch 2/2. i split it up as it touches a
> different subsystem. I can put both changes into the same patch.
> would that be acceptable ?

That would make more sense, don't you think?

greg k-h

<Prev in Thread] Current Thread [Next in Thread>