linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] tty: of_serial: allow rt288x-uart to load from OF

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 1/3] tty: of_serial: allow rt288x-uart to load from OF
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Mon, 15 Apr 2013 11:14:02 -0700
Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=yMsroIj7GP89V9Be+Sv3KR9zz7z6oO2ES1SimVRJktw=; b=fvBFswVg1MFqYprSwfymRRSF8cvGMb2qVZwxY846Iv4siV+UiJTEMf93JToXsU1CzG N6H+d4PlWrGr1WBYKHPLZ8HIdFu3TzEt3+q041QCU/MNNC2jZUSqNVW4Xx7vQA63x5ii LrHZfR3K3EBNuJdm5A2masdOHRYGYOoTv4/Ok=
In-reply-to: <1365845618-16040-2-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1365845618-16040-1-git-send-email-blogic@openwrt.org> <1365845618-16040-2-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Apr 13, 2013 at 11:33:36AM +0200, John Crispin wrote:
> In order to make serial_8250 loadable via OF on Ralink WiSoC we need to 
> default
> the iotype to UPIO_RT.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>  drivers/tty/serial/of_serial.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index b025d54..42f8550 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -98,7 +98,10 @@ static int of_platform_serial_setup(struct platform_device 
> *ofdev,
>               port->regshift = prop;
>  
>       port->irq = irq_of_parse_and_map(np, 0);
> -     port->iotype = UPIO_MEM;
> +     if (of_device_is_compatible(np, "ralink,rt2880-uart"))
> +             port->iotype = UPIO_AU;
> +     else
> +             port->iotype = UPIO_MEM;

Why are you putting device-specific things into a generic driver?
Shouldn't this be able to be described in device tree without relying on
an vendor-specific test in this driver?

greg k-h

<Prev in Thread] Current Thread [Next in Thread>