linux-mips
[Top] [All Lists]

Re: [PATCH V2 09/16] MIPS: ralink: adds support for RT2880 SoC family

To: Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH V2 09/16] MIPS: ralink: adds support for RT2880 SoC family
From: John Crispin <blogic@openwrt.org>
Date: Fri, 12 Apr 2013 13:19:10 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <5167EC0A.8020003@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1365751663-5725-1-git-send-email-blogic@openwrt.org> <1365751663-5725-9-git-send-email-blogic@openwrt.org> <5167EC0A.8020003@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 12/04/13 13:12, Gabor Juhos wrote:
The commit log says that the code registers the pinmux settings. However the
patch only contains the definitions of the pinmux groups without doing anything
with those. Additionally, the structures and the 'rt288x_wdt_reset' function
should be static.

However converting them to static would cause compiler warnings about unused
variables/functions. So it would be simpler to remove these. You have removed
the pinmux driver from the series anyway, and this part can't be used without 
that.


the same was done for rt305x and causes no harm, so I really don't see a problem with adding these now.

i will address the "static" bit for the next series



<Prev in Thread] Current Thread [Next in Thread>