[Top] [All Lists]

Re: [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node

To: Bjorn Helgaas <>
Subject: Re: [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node
From: John Crispin <>
Date: Wed, 10 Apr 2013 18:53:22 +0200
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 10/04/13 18:31, Bjorn Helgaas wrote:
On Thu, Apr 4, 2013 at 12:01 PM, Gabor Juhos<>  wrote:
The of_node field of the device assigned to a
PCI bus is used during scanning of the PCI bus.
However on MIPS, the of_node field is assigned
only after the bus has been scanned.

Implement the architecture specific version of
'pcibios_get_phb_of_node'. Which ensures that the
PCI driver core will initialize the of_node field
before starting the scan.

Also remove the local assignment of bus->dev.of_node,
it is not needed after the patch.

Signed-off-by: Gabor Juhos<>

I removed the __weak annotation from include/linux/pci.h and applied
this patch to my pci/gabor-get-of-node.  Give it a try and make sure
it solves your problem.  If so, and Ralph approves, I can push both
for v3.10.  It should appear at

Or if you prefer, you can take them through the MIPS tree.



having them go via the PCI tree is fine. I will mark them as "Other Subsystem" in our Patchwork


<Prev in Thread] Current Thread [Next in Thread>